Skip to content

chore(deps-dev): bump fetch-mock from 11.1.5 to 12.6.0 in /superset-frontend/packages/superset-ui-core#36662

Merged
hainenber merged 6 commits into
masterfrom
dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0
Jan 30, 2026
Merged

chore(deps-dev): bump fetch-mock from 11.1.5 to 12.6.0 in /superset-frontend/packages/superset-ui-core#36662
hainenber merged 6 commits into
masterfrom
dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Dec 16, 2025

Bumps fetch-mock from 11.1.5 to 12.6.0.

Release notes

Sourced from fetch-mock's releases.

fetch-mock: v12.6.0

12.6.0 (2025-10-29)

Features

  • implement host: matcher (2b0a43d)

Documentation Changes

  • document new host matcher (6205357)

fetch-mock: v12.5.6

12.5.6 (2025-10-27)

Bug Fixes

  • clean abort event listener once it's called or response is returned (4606250)
  • clean abort event listener once it's called or response is returned (ca51920)

fetch-mock: v12.5.5

12.5.5 (2025-10-21)

Bug Fixes

  • do not try to get a reader from a locked request oder response to cancel them (8c23ecf)
  • use optional chaining operator and do not try to cancel locked request or response to prevent errors (b1ff114)
  • use optional chaining operator to prevent errors (87f8399)

fetch-mock: v12.5.4

12.5.4 (2025-08-28)

Bug Fixes

  • apply browser exports fix for fetch-mock package (318cd94)

fetch-mock: v12.5.3

12.5.3 (2025-06-17)

Bug Fixes

  • add wrapper class to fix type ambiguity (b093bb0)
  • add wrapper class to fix type ambiguity (ea45aec)

fetch-mock: v12.5.2

... (truncated)

Changelog

Sourced from fetch-mock's changelog.

12.6.0 (2025-10-29)

Features

  • implement host: matcher (2b0a43d)

Documentation Changes

  • document new host matcher (6205357)

12.5.6 (2025-10-27)

Bug Fixes

  • clean abort event listener once it's called or response is returned (4606250)
  • clean abort event listener once it's called or response is returned (ca51920)

12.5.5 (2025-10-21)

Bug Fixes

  • do not try to get a reader from a locked request oder response to cancel them (8c23ecf)
  • use optional chaining operator and do not try to cancel locked request or response to prevent errors (b1ff114)
  • use optional chaining operator to prevent errors (87f8399)

12.5.4 (2025-08-28)

Bug Fixes

  • apply browser exports fix for fetch-mock package (318cd94)

12.5.3 (2025-06-17)

Bug Fixes

  • add wrapper class to fix type ambiguity (b093bb0)
  • add wrapper class to fix type ambiguity (ea45aec)

12.5.2 (2025-03-03)

Bug Fixes

  • allow matching body for delete requests (891197c)

... (truncated)

Commits
  • 4871184 chore: release main
  • 32fdb1b test: fixed browser test for host matching
  • c50e42d chore: run prettier
  • 2b0a43d feat: implement host: matcher
  • 6205357 docs: document new host matcher
  • 6720a98 test: added failing test for host: matcher
  • 346d867 chore: release main
  • ca51920 fix: clean abort event listener once it's called or response is returned
  • e7a29e8 chore: release main
  • 9cdfe9d test: add test for optional chaining for route in call history
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependabot npm Dependabot - npm related PRs labels Dec 16, 2025
@codeant-ai-for-open-source
Copy link
Copy Markdown
Contributor

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Dec 16, 2025

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch from 4f9de62 to 28c270c Compare December 24, 2025 07:10
@rusackas
Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch from 28c270c to 448d6e7 Compare January 16, 2026 03:13
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit bfcbf03
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/697cbb34fa4ab40008efde43
😎 Deploy Preview https://deploy-preview-36662--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas
Copy link
Copy Markdown
Member

@hainenber any interest in fixing this up? If not, close it out please :D

@hainenber
Copy link
Copy Markdown
Contributor

I'm taking a look :D

@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch from 448d6e7 to 2ca2aba Compare January 24, 2026 19:37
@hainenber
Copy link
Copy Markdown
Contributor

There are lots of breaking changes in fetch-mock v12 compared to v11. I'm working on the mass refactor for fetch-mock usage on the whole codebase, FYI.

@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch from 2ca2aba to b386e9f Compare January 26, 2026 06:27
@rusackas
Copy link
Copy Markdown
Member

This PR has CI failures due to npm dependency resolution issues causing query-string to be resolved to an ESM-only version and global-box to go missing. The lockfile needs careful manual regeneration to fix these transitive dependency issues.

Errors:

  • Jest: SyntaxError: Cannot use import statement outside a module (query-string ESM issue)
  • Storybook: Module not found: Error: Can't resolve 'global-box' (encodable dependency)

This requires manual intervention to properly regenerate the lockfile while pinning transitive dependencies correctly.

Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock/tree/HEAD/packages/fetch-mock) from 11.1.5 to 12.6.0.
- [Release notes](https://github.com/wheresrhys/fetch-mock/releases)
- [Changelog](https://github.com/wheresrhys/fetch-mock/blob/main/packages/fetch-mock/CHANGELOG.md)
- [Commits](https://github.com/wheresrhys/fetch-mock/commits/fetch-mock-v12.6.0/packages/fetch-mock)

---
updated-dependencies:
- dependency-name: fetch-mock
  dependency-version: 12.6.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@rusackas rusackas force-pushed the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch from b386e9f to 28f495f Compare January 27, 2026 00:00
@rusackas
Copy link
Copy Markdown
Member

Rebased on master after PR #37450 merged, which fixed the query-string/encodable ESM issue. The lockfile has been regenerated and this PR is ready for review.

Regenerate lockfile after rebase on master to sync with fetch-mock upgrade.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rusackas
Copy link
Copy Markdown
Member

CI is failing because fetch-mock 12.x is a major version bump with breaking API changes. Tests that assert on fetchMock.calls() counts are failing — the new version has different call tracking behavior.

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Copy Markdown
Contributor

@rusackas can you take a look at this? Changes I pushed only caters to fetch-mock v12's breaking changes, i.e. modifying .calls() to .callHistory.calls(), remove deprecated {overwriteRoutes: true} and alike.

Since all changes are for Jest tests so I think we have a passing acceptance threshold :D

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the touch-up @hainenber - needs a rebase, but approving so you can fix/merge :)

@hainenber hainenber merged commit 66519c3 into master Jan 30, 2026
68 of 69 checks passed
@hainenber hainenber deleted the dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-mock-12.6.0 branch January 30, 2026 14:27
@bito-code-review
Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

sadpandajoe added a commit that referenced this pull request Feb 3, 2026
Change fetchMock.restore() to fetchMock.removeRoutes() to match
the fetch-mock v12 API introduced in PR #36662.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Mar 5, 2026
…rontend/packages/superset-ui-core (apache#36662)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: hainenber <dotronghai96@gmail.com>
alex-poor pushed a commit to alex-poor/superset that referenced this pull request Mar 15, 2026
…rontend/packages/superset-ui-core (apache#36662)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: hainenber <dotronghai96@gmail.com>
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…rontend/packages/superset-ui-core (apache#36662)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: hainenber <dotronghai96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants