chore(deps-dev): bump fetch-mock from 11.1.5 to 12.6.0 in /superset-frontend/packages/superset-ui-core#36662
Conversation
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
|
Bito Automatic Review Skipped - Files Excluded |
4f9de62 to
28c270c
Compare
|
@dependabot rebase |
28c270c to
448d6e7
Compare
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@hainenber any interest in fixing this up? If not, close it out please :D |
|
I'm taking a look :D |
448d6e7 to
2ca2aba
Compare
|
There are lots of breaking changes in fetch-mock v12 compared to v11. I'm working on the mass refactor for fetch-mock usage on the whole codebase, FYI. |
2ca2aba to
b386e9f
Compare
|
This PR has CI failures due to npm dependency resolution issues causing Errors:
This requires manual intervention to properly regenerate the lockfile while pinning transitive dependencies correctly. |
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock/tree/HEAD/packages/fetch-mock) from 11.1.5 to 12.6.0. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Changelog](https://github.com/wheresrhys/fetch-mock/blob/main/packages/fetch-mock/CHANGELOG.md) - [Commits](https://github.com/wheresrhys/fetch-mock/commits/fetch-mock-v12.6.0/packages/fetch-mock) --- updated-dependencies: - dependency-name: fetch-mock dependency-version: 12.6.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b386e9f to
28f495f
Compare
|
Rebased on master after PR #37450 merged, which fixed the query-string/encodable ESM issue. The lockfile has been regenerated and this PR is ready for review. |
Regenerate lockfile after rebase on master to sync with fetch-mock upgrade. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
CI is failing because fetch-mock 12.x is a major version bump with breaking API changes. Tests that assert on |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
|
@rusackas can you take a look at this? Changes I pushed only caters to Since all changes are for Jest tests so I think we have a passing acceptance threshold :D |
rusackas
left a comment
There was a problem hiding this comment.
Thanks for the touch-up @hainenber - needs a rebase, but approving so you can fix/merge :)
…packages/superset-ui-core/fetch-mock-12.6.0
|
Bito Automatic Review Skipped – PR Already Merged |
Change fetchMock.restore() to fetchMock.removeRoutes() to match the fetch-mock v12 API introduced in PR #36662. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…rontend/packages/superset-ui-core (apache#36662) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@rusackas.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: hainenber <dotronghai96@gmail.com>
…rontend/packages/superset-ui-core (apache#36662) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@rusackas.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: hainenber <dotronghai96@gmail.com>
…rontend/packages/superset-ui-core (apache#36662) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@rusackas.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: hainenber <dotronghai96@gmail.com>
Bumps fetch-mock from 11.1.5 to 12.6.0.
Release notes
Sourced from fetch-mock's releases.
... (truncated)
Changelog
Sourced from fetch-mock's changelog.
... (truncated)
Commits
4871184chore: release main32fdb1btest: fixed browser test for host matchingc50e42dchore: run prettier2b0a43dfeat: implement host: matcher6205357docs: document new host matcher6720a98test: added failing test for host: matcher346d867chore: release mainca51920fix: clean abort event listener once it's called or response is returnede7a29e8chore: release main9cdfe9dtest: add test for optional chaining for route in call historyYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)